Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move references for serialize_json_safe() to raiutils #1536

Merged
merged 2 commits into from
Jul 7, 2022
Merged

Move references for serialize_json_safe() to raiutils #1536

merged 2 commits into from
Jul 7, 2022

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Jul 6, 2022

Description

Move references for serialize_json_safe() to raiutils

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@gaugup
Move references for serialize_json_safe() to raiutils
978202f 
Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2022 •
edited
Loading

Codecov Report

Merging #1536 (a32c9a8) into main (9e0693b) will increase coverage by 8.67%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1536      +/-   ##
==========================================
+ Coverage   78.65%   87.32%   +8.67%     
==========================================
  Files          29      107      +78     
  Lines        1527     5040    +3513     
==========================================
+ Hits         1201     4401    +3200     
- Misses        326      639     +313
Flag Coverage Δ
unittests 87.32% <100.00%> (+8.67%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
raiwidgets/raiwidgets/dashboard.py 92.68% <100.00%> (ø)
...dgets/raiwidgets/error_analysis_dashboard_input.py 66.09% <100.00%> (-0.12%) ⬇️
...iwidgets/raiwidgets/explanation_dashboard_input.py 59.85% <100.00%> (-0.29%) ⬇️
...sibleai/responsibleai/_tools/shared/base_result.py 95.65% <100.00%> (ø)
...onsibleai/responsibleai/serialization_utilities.py 96.55% <100.00%> (ø)
...bleai/responsibleai/_tools/causal/causal_result.py 96.33% <0.00%> (ø)
...ai/responsibleai/_tools/causal/causal_constants.py 100.00% <0.00%> (ø)
...ponsibleai/responsibleai/_managers/base_manager.py 100.00% <0.00%> (ø)
...bleai/responsibleai/_managers/explainer_manager.py 100.00% <0.00%> (ø)
...ponsibleai/responsibleai/_tools/causal/__init__.py 100.00% <0.00%> (ø)
... and 73 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e0693b...a32c9a8. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jul 6, 2022

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/gaugup/Replace_serialize_json_safe/dashboard/index.html

@gaugup
Merge branch 'main' into gaugup/Replace_serialize_json_safe
a32c9a8 
Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
@gaugup gaugup enabled auto-merge (squash) July 7, 2022 17:03
@github-actions
Copy link

github-actions bot commented Jul 7, 2022

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/gaugup/Replace_serialize_json_safe/dashboard/index.html

@gaugup gaugup merged commit c5c5c80 into main Jul 7, 2022
@gaugup gaugup deleted the gaugup/Replace_serialize_json_safe branch July 7, 2022 18:26
@imatiach-msft imatiach-msft mentioned this pull request Jul 18, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imatiach-msft imatiach-msft imatiach-msft approved these changes

@xuke444 xuke444 Awaiting requested review from xuke444 xuke444 is a code owner

@kicha0 kicha0 Awaiting requested review from kicha0 kicha0 is a code owner

@romanlutz romanlutz Awaiting requested review from romanlutz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaugup @codecov-commenter @imatiach-msft